Skip to content

Conversation

@calixtus
Copy link
Member

@calixtus calixtus commented Oct 19, 2025

Self describing.
Removed also artifact from #13867

Feel free to pick some classes and push some commits with null fixes to this PR.

Steps to test

Run gradle :jablib:build, see if null warnings have bin fixed.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@calixtus calixtus added the dev: code-quality Issues related to code or architecture decisions label Oct 19, 2025

applyFilter(request.filter()).forEach(id -> {
EmbeddingRecord eRecord = embeddingsMap.get(id);
EmbeddingRecord eRecord = embeddingsMap.getOrDefault(id, new EmbeddingRecord(null, "", new float[0]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could think about a NULL_OBJECT constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants